Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to hide Number of items closed metric #313

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Jun 11, 2024

Pull Request

fixes #309

Proposed Changes

This pull request introduces a new environment variable HIDE_ITEMS_CLOSED_COUNT to control whether the number of items closed metric should be displayed in the generated Markdown file.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@zkoppert zkoppert marked this pull request as ready for review June 11, 2024 17:54
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
@zkoppert zkoppert merged commit a3ac7ff into main Jun 12, 2024
26 checks passed
@zkoppert zkoppert deleted the hide-closed-count branch June 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to hide Number of items closed Metric in the overview table
3 participants